Ensure proper unprivileged user if pihole-FTL is started as root #2394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]
git rebase
)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
Ensure that when pihole-FTL is launched as user
root
(it will drop permissions as soon as this is possible), it drops down topihole:pihole
instead of the defaultnobody:nogroup
.This is necessary as
pihole-FTL
needs to be able to periodically create new files - namely the SQLite3 rollback journals - in/etc/pihole
. As usernobody
, however, cannot do this, the current way of handling this leads to a failure of our long-term database implementation.How does this PR accomplish the above?:
Use appropriate
dnsmasq
options to instruct the code to not go tonobody:nogroup
but ratherpihole:pihole
.