Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for validity of values passed in through PIHOLE_DNS_ #839

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

PromoFaux
Copy link
Member

Description

Adds a check using the already sourced valid_ip and valid_ip6 functions from basic-install.sh to ensure that any duff values passed in through PIHOLE_DNS_ are junked

Motivation and Context

See discussion here: #838

How Has This Been Tested?

Built it, tried it:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PromoFaux PromoFaux requested a review from a team April 16, 2021 21:59
@PromoFaux
Copy link
Member Author

image

Copy link
Contributor

@kylekurz kylekurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PromoFaux PromoFaux merged commit 784be64 into dev Apr 17, 2021
@PromoFaux PromoFaux deleted the tweak/valid_ip branch April 17, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants