-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RISC-V 64-bit container builds #63
Conversation
Have you tested some of the stand-alone features of FTL on your hardware to see if it actually runs when built by this container? I'm thinking about some easy things:
Others that that: I've tried building your docker container locally but it failed with:
The hint works, when moving edit Part of the comment removed, I see you force-pushed a new version which fixed what I've seen. I'm running these test on an |
The part solved with initially missing
So far only some quick tests with |
Tested, works, here a debug token to have a closer look: https://tricorder.pi-hole.net/kcm5p3sW/ Here the binary if someone else wants to test/look: https://dietpi.com/downloads/binaries/pihole-FTL-riscv64-linux-gnu Doubles partly with debug log, but for completeness: root@DietPi:~# pihole-FTL sqlite3
Pi-hole FTL v5.21-2-g04488d11
SQLite version 3.40.0 2022-11-16 12:10:08
Enter ".help" for usage hints.
Connected to a transient in-memory database.
Use ".open FILENAME" to reopen on a persistent database.
sqlite> .quit
root@DietPi:~# pihole-FTL lua
Pi-hole FTL v5.21-2-g04488d11
Lua 5.4.4 Copyright (C) 1994-2022 Lua.org, PUC-Rio
> ^C
root@DietPi:~# pihole-FTL dhcp-discover
Scanning all your interfaces for DHCP servers
Timeout: 10 seconds
WARN: Could not sendto() in send_dhcp_discover() (/root/FTL/src/dhcp-discover.c:233): Network is unreachable
* Received 548 bytes from eth0:192.168.178.1
Offered IP address: 192.168.178.22
Server IP address: 192.168.178.1
Relay-agent IP address: N/A
BOOTP server: (empty)
BOOTP file: (empty)
DHCP options:
Message type: DHCPOFFER (2)
server-identifier: 192.168.178.1
lease-time: 86400 ( 1d )
renewal-time: 43200 ( 12h )
rebinding-time: 75600 ( 21h )
netmask: 255.255.255.0
router: 192.168.178.1
dns-server: 192.168.178.2
domain-name: "fritz.box"
broadcast: 192.168.178.255
ntp-server: 192.168.178.1
Port Control Protocol (PCP) server: 192.168.178.1
^C
root@DietPi:~# pihole-FTL dnsmasq-test
dnsmasq: syntax check OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debug log looks fine. Excellent job, thanks!
@MichaIng Do you have IPv6 disabled (via |
The kernel does not support it at all: root@DietPi:~# modinfo ipv6
modinfo: ERROR: Module ipv6 not found. This is the kernel provided by StarFive, which lacks quick some features. I'll try doing an own build next week. |
@MichaIng rebase on latest master and force push please - I've tweaked the actions |
Generally
|
Signed-off-by: MichaIng <[email protected]> Co-authored-by: DL6ER <[email protected]>
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Adding RISC-V 64-bit container builds.
How does this PR accomplish the above?:
riscv64
Dockerfileriscv64
target to FTL builds and base image workflows.git
package fromaarch64
DockerfileEDIT: Using Debian Sid base container now, since
libc6-dev:riscv64
depends on recent versions of glibc packages anyway, which forcefully upgrades a Buster system to Sid in relevant parts anyway. On case builds for older glibc are needed, flags would need to be passed.EDIT: Tested the steps manually on a Sid VM with Add RISC-V 64-bit support and builds FTL#1536 and the build goes through and produces an executable FTL which can be started and shows CLI via
qemu-riscv64-static
. Adjusted binary tests in Add RISC-V 64-bit support and builds FTL#1536 to match the results. Test on physical RISC-V system outstanding.Companion PRs:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)