Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ownership of all shared memory objects before switching user #671

Merged
merged 1 commit into from
Dec 28, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 27, 2019

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Change ownership of all shared memory objects to the user/group configured in /etc/dnsmasq.d/01-pihole.conf. We already do this for pihole-FTL.log and pihole-FTL.db but forgot to do this for the shm objects.

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on #569 (comment)

@DL6ER DL6ER merged commit bdfd955 into development Dec 28, 2019
@DL6ER DL6ER deleted the fix/chown/shm-files branch December 28, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants