Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior when no whitelist file is present #388

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 26, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


  • Don't return -1 as number of read whitelist domains if there is no whitelist file.
  • Also, don't try to free the array of whitelist domains if there are none.

Both "bugs" are harmless, I have just seen them on a fresh install.

This template was created based on the work of udemy-dl.

…itelist file. Also, don't try to free the array of whitelist domains if there are none.

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER added the Bugfix label Sep 26, 2018
@DL6ER DL6ER requested a review from a team September 26, 2018 10:50
@DL6ER DL6ER merged commit 7a74acc into development Sep 26, 2018
@DL6ER DL6ER deleted the fix/no_whitelist branch September 26, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants