Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count locally blocked queries as externally blocked #374

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

AzureMarker
Copy link
Contributor

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


Previously the externally blocked query check only considered the answer IP address, so it marked queries blocked by gravity.list and regex.list as externally blocked. Now it will skip locally resolved queries (with the F_HOSTS flag).

This template was created based on the work of udemy-dl.

@AzureMarker AzureMarker requested a review from a team September 3, 2018 15:30
@AzureMarker AzureMarker merged commit 061b19e into development Sep 3, 2018
@AzureMarker AzureMarker deleted the fix/gravity-blocked-externally-blocked branch September 3, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants