Improve memory checks #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- calloc, - realloc, - free, and - strdup These functions will not directly improve memory handling but they will log if something will go wrong *before* it actually goes wrong. This will ease debugging when user provide log snippets especially in ENOMEM (no memory available) situations. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…ion events at the places we need the allocated space Signed-off-by: DL6ER <[email protected]>
AzureMarker
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
With this PR, we add our own memory handling functions that will detect possible errors and report accordingly in the log. This will make debugging FTL crashes caused by insufficient memory or by code bugs (not properly dealing with
NULLpointers) much easier.We also rename
struct.c -> memory.cas this is a more obvious choice for a file that does only contain functions that deal with memory operations. Accordingly, I also move allvalidate_access*functions fromparser.ctomemory.cwithout changing them.Furthermore, we add pointer validation for allocated memory in a few places where they have been missing, sometimes even when a
NULLpointer would not be a problem.If we cannot get this PR reviewed before the release of
v3.0then it should not be a blocker and can be directed for merging intodevelopment.This template was created based on the work of
udemy-dl.