-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve -vv and --help #1501
Improve -vv and --help #1501
Conversation
…evamp the help function Signed-off-by: DL6ER <[email protected]>
…ine after dnsmasq-test) Signed-off-by: DL6ER <[email protected]>
…rol sequence as spellchecking error Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--hash
, d
, handling of --
(dnsmasq
options), -q
are missing from the help section.
(Some more as well, but I think the above should be part of the help text)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one thing I don't like in codespell.
You had to change a perfectly correct line of code (and removed some text: "the optional") just to please the checker.
Signed-off-by: DL6ER <[email protected]>
Thanks for your comments. I added the missing bits with the exception of the I'll leave the code here in case you still think we need it: printf("\t%s-- args...%s Collect arguments behind %s--%s for\n", green, normal, green, normal);
printf("\t the embedded dnsmasq server\n"); I also don't think we should always include all variants of an option, e.g, Furthermore, I replaced Updated screenshot: |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-and-web-v5-18-released/59959/1 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/v6-development-branch-man-page-gone/72644/8 |
What does this implement/fix?
This PR adds colors (if supported by the terminal) to verbose version output and completely revamps the help function.
When the "consumer" is not a terminal (e.g. a pipe), no escape sequences will be added.
pihole-FTL -vv
BEFOREpihole-FTL -vv
NOWpihole-FTL -h
BEFOREpihole-FTL -h
NOWRelated issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.