Update embedded dnsmasq to v2.88rc1 #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a confusion if certain algorithms are not supported because the version is the crypto library is too old. The validation should be treated the same as for a completely unknown algorithm, (ie return unverified answer) and not as a validation failure (ie return SERVFAIL). The algorithems affected are GOST and ED448. Signed-off-by: DL6ER <[email protected]>
Use CryptoPro version of the hash function. Handle the little-endian wire format of key data. Get the wire order of S and R correct. Note that Nettle version 3.6 or later is required for GOST support. Signed-off-by: DL6ER <[email protected]>
Such a DS, as long as it is validated, should allow answers in the domain is attests to be returned as unvalidated, and not as a validation error. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
yubiuser
approved these changes
Nov 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Update embedded dnsmasq to
v2.88rc1How does this PR accomplish the above?:
Incorporate three commits from upstream
dnsmasq. Noteworthy Changelog entry is:We are not affected by the fix in c030b2d as it only affects older versions of
nettlelower than 3.6 (FTL is built against the most recent version 3.8.1).BEFORE (current
masteranddevelopment)NOW (this branch)
This is the
rootcanary.orgtest. Records signed withRSA-MD5,DSAandDSA-NSEC-SHA1are returned without being verified as specified in the DNSSEC Validation column of RFC 8624 para 3.1.Link documentation PRs if any are needed to support this PR:
-/-
By submitting this pull request, I confirm the following:
git rebase)