Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status of blocked special domains when they are in FTL's DNS cache #1383

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 8, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


When querying special domains (such as use-application-dns.net), they are getting logged with status 16 (Blocked (special domain)). However, subsequent queries to the same domain incorrectly get status OK (cached). This PR fixes these subsequent queries to also show status 16. This big is a mere displaying issue, blocking works as expected.

Thanks to @jpgpi250 for pointing this out.

@DL6ER DL6ER added the Bugfix label Jul 8, 2022
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two are on the development the latter on the current branch

Bildschirmfoto zu 2022-07-08 22-45-17

@yubiuser yubiuser merged commit faab0fe into development Jul 8, 2022
@yubiuser yubiuser deleted the fix/special_domains branch July 8, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants