Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conditional domain suffices in HOSTNAMEFQDN mode #1250

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 29, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Add support for conditional domain suffices in HOSTNAMEFQDN mode. Fixes #1247

@regae
Copy link

regae commented Nov 29, 2021

i can confirm, my issue has been fixed with this PR.
thank you

@DL6ER DL6ER marked this pull request as ready for review November 29, 2021 16:21
@yubiuser
Copy link
Member

Just for me to understand:

Given a dnsmasq config like

domain=lan,192.168.55.0/24,local
domain=guest,192.168.66.0/24,local
domain=iot,192.168.77.0/24,local

And setting PIHOLE_PTR=HOSTNAMEFQDN, FTL will now reply to PTR requests arriving from 192.168.55.0 with HOSTNAME.lan and from 192.168.66.0 with HOSTNAME.guest and so on?

@DL6ER
Copy link
Member Author

DL6ER commented Nov 30, 2021

Yes, exactly. You could even specify an exact address like

domain=lan,192.168.55.0/24
domain=other,192.168.55.2

so all devices in the range 192.168.55.0/24 will become hostname.lan, except for 192.168.55.2 which would become hostname.other

@DL6ER DL6ER merged commit 1729c28 into development Nov 30, 2021
@DL6ER DL6ER deleted the tweak/conditional_domainsuffix branch November 30, 2021 16:06
@DL6ER DL6ER mentioned this pull request Dec 20, 2021
5 tasks
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants