Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about resource shortages #1249

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Warn about resource shortages #1249

merged 5 commits into from
Dec 1, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 29, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Warn about resource shortages (15min load average exceeding number of cores, available disk space for database and log file, and available shared memory (RAM))

Connected web interface PR (incl. a screenshot): pi-hole/web#1989

… cores, available disk space for database and log file, and available shared memory (RAM))

Signed-off-by: DL6ER <[email protected]>
…ng levels and disabling warnings.

Signed-off-by: DL6ER <[email protected]>
src/config.c Outdated Show resolved Hide resolved
src/database/message-table.c Show resolved Hide resolved
@DL6ER DL6ER force-pushed the tweak/warn_resources branch from 6cf7948 to 7a35a22 Compare November 29, 2021 16:50
@DL6ER DL6ER force-pushed the tweak/warn_resources branch from 7a35a22 to ff16446 Compare November 29, 2021 17:55
@DL6ER DL6ER requested a review from PromoFaux November 29, 2021 17:56
yubiuser
yubiuser previously approved these changes Nov 30, 2021
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving, provided that the documentation for the new config options is still done.

src/gc.c Outdated Show resolved Hide resolved
@DL6ER
Copy link
Member Author

DL6ER commented Nov 30, 2021

Documentation is added in pi-hole/docs#607

@DL6ER DL6ER merged commit d53b0f6 into development Dec 1, 2021
@DL6ER DL6ER deleted the tweak/warn_resources branch December 1, 2021 06:08
@DL6ER DL6ER mentioned this pull request Dec 20, 2021
5 tasks
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants