Skip to content

Commit

Permalink
Correct IconControlProps to include an onClick definition (elastic#3581)
Browse files Browse the repository at this point in the history
* Correct IconControlProps to include an onClick definition

* changelog
  • Loading branch information
chandlerprall authored and phyolim committed Jun 11, 2020
1 parent dd97210 commit 1f32f88
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Fixed DOM element creation issues in `EuiOverlayMask` by using lifecycle methods ([#3555](https://github.com/elastic/eui/pull/3555))
- Fixed `EuiComboBox`'s options list `zIndex` positioning when nested in other `zIndex` contexts ([#3551](https://github.com/elastic/eui/pull/3551))
- Fixed `euiHeaderAffordForFixed` mixin's use of header SASS variable ([#3592](https://github.com/elastic/eui/pull/3592))
- Included `onClick` as a valid prop for `EuiControlBar` **icon** controls ([#3581](https://github.com/elastic/eui/pull/3581))

**Breaking changes**

Expand Down
2 changes: 2 additions & 0 deletions src/components/control_bar/control_bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import React, {
ButtonHTMLAttributes,
Component,
HTMLAttributes,
MouseEventHandler,
Ref,
} from 'react';
import { EuiScreenReaderOnly } from '../accessibility';
Expand Down Expand Up @@ -119,6 +120,7 @@ export interface IconControlProps {
controlType: 'icon';
id: string;
iconType: string;
onClick?: MouseEventHandler;
}

/**
Expand Down

0 comments on commit 1f32f88

Please sign in to comment.