Add option to disable lockfile generation #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd-work
requested review from
maxrake and
kylewillmon
and removed request for
maxrake
maxrake
requested changes
Nov 9, 2023
There was a problem hiding this comment.
First pass quick review:
- CHANGELOG entry needed
- Docs need to be regenerated
- There is a deno check failure in CI
- Add more detail to the lockfile generation page for explaining the options for opt-out
maxrake
requested changes
Nov 13, 2023
cd-work
force-pushed
the
force_disable_generation
branch
from
2983838 to
79dc79d
Compare
maxrake
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1094