After resume from sleep OGCS attempts sync before network becomes available.

[kuraikaze]

OGCS Version: v2.10.4.0
Edition: Installed
Sync Direction: O<->G

Bug Description
After PC resumes from S3 sleep or hibernation OGCS attempts a sync cycle immediately, frequently before the network stack has completed re-initialisation, leading to a connection failure which generates the error popup.

Steps to Reproduce the Issue

1. Sleep/hibernate PC
2. Resume PC.

Any other information
Regression to behaviour from closed issues #886, #1144

📎 OGcalsync.log gist
(Resume event at 2024-04-14 08:54:11,214)

[phw198]

Thanks for reporting @kuraikaze 👍🏻

📦 Hopefully this should now be resolved with hotfix v2.10.4.2.zip (see instructions for applying).
      CRCs: Zip = 611B5D18 Exe = 9DFB1E62

Let me know how it goes.

[kuraikaze]

Thanks for the update. Almost there with the hotfix...
The app no longer brings up it's window and an error popup upon resume but it still generates a Windows Notification:-
"Issue encountered.
Please review output on the main 'Sync' tab"

The app then successfully completed a sync after a few minutes, before I got a chance to look at the details in the Sync window.
I've turned on Debug logging and I'll include the log next time I do a sleep/resume cycle.

[kuraikaze]

Gist of log for Hotfix version.
Resume event at 2024-04-22 19:32:01 : OGcalsync.log 2.10.4.2-hotfix

[phw198]

Thanks @kuraikaze, I think that looks correct and I'm sure that was its behaviour before v2.10.4 - it should report the error (but only in the sync window and not as a popup message box) and automatically retry within 15 minutes.

[kuraikaze]

Yep - the only difference now is that the initial error at resume time generates a Windows Notification, which didn't happen prior to V2.10.4

[phw198]

That's more of an intentional change to always have a system notification when there are errors. However, as per #1840 it probable needs some refinement with maybe 4 options to chose from: no notifications / only errors / errors + changes / all.

[kuraikaze]

Something like that would work for me. Or, perhaps "Notify only after 2 consecutive errors"
Alternatively, could there be a mechanism to delay the first sync after resume for, say, 15 seconds ?
I'm not familiar enough with the internals of Windows to know if there's any easily accessible method to inform userland applications of the S3 resume event.

[phw198]

@kuraikaze I've created #1850 to see if we can delay syncs immediately after resume - please have a go with the hotfix there.