Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "Sync Failed" modal dialog boxes overwhelm #1150

Open
sVathis opened this issue Jan 13, 2021 · 14 comments
Open

Avoid "Sync Failed" modal dialog boxes overwhelm #1150

sVathis opened this issue Jan 13, 2021 · 14 comments
Assignees
Labels
bug Something's not working right waiting fix confirmation Hotfix available for testing

Comments

@sVathis
Copy link

sVathis commented Jan 13, 2021

When a sync fails for a perfectly valid reason (e.g. no network connectivity) a "Sync Failed" modal dialog box pops up.
If the sync is executed frequently (and/or multiple instances of OGCS are running with different parent windows) user is overwhelmed by dialog boxes that are very difficult to close as user need to find and click the parent window in order for the dialog box to come on top before clicking the Yes/No button.
image

"Sync failed" messages could be issued inside the main application window, without using a dialog box. Default behavior (try again or not) could be set by a configuration option.

@sVathis sVathis added the enhancement New feature label Jan 13, 2021
@phw198
Copy link
Owner

phw198 commented Jan 14, 2021

Looks like a duplicate of #886

@sVathis
Copy link
Author

sVathis commented Jan 15, 2021

Probably so. Will try hotfix 2.8.5.11 and will let you know.

@ik8sqi
Copy link

ik8sqi commented Jun 10, 2021

FYI this is not fixed in 2.8.7.0. When logging in via VPN to our corporate network, the VPN blocks internet access unless a proxy server is configured. When that happens (VPN but no proxy) OGCS has access to our Exchange but does not have access to the internet. That's when the flood of "Sync Failed" popups occurs.

Untitled5

@phw198 phw198 added bug Something's not working right more info needed Not enough detail provided to fully troubleshoot and removed enhancement New feature labels Jun 19, 2021
@phw198
Copy link
Owner

phw198 commented Jun 19, 2021

Looks like the issue might have resurfaced in v2.8.7.

@ik8sqi Please provide your OGcalsync.log file (see instructions) after you have encountered this issue. Thanks

@ik8sqi
Copy link

ik8sqi commented Jun 22, 2021

Looks like the issue might have resurfaced in v2.8.7.

@ik8sqi Please provide your OGcalsync.log file (see instructions) after you have encountered this issue. Thanks

Here it is:
https://gist.github.com/ik8sqi/ddc9611062439b1c08c8d62abeddead2

@phw198
Copy link
Owner

phw198 commented Jun 27, 2021

Thanks - and this does look to be different from #886.

📦 Please confirm if this is now resolved with hotfix v2.8.7.1.zip (see instructions for applying).

@phw198 phw198 self-assigned this Jun 27, 2021
@phw198 phw198 added waiting fix confirmation Hotfix available for testing and removed more info needed Not enough detail provided to fully troubleshoot labels Jun 27, 2021
@ik8sqi
Copy link

ik8sqi commented Jun 29, 2021 via email

@phw198
Copy link
Owner

phw198 commented Jun 29, 2021

That looks like a different test - previously you had already successfully authenticated with Google, then your VPN was down and OGCS could not talk to Exchange. Could you test v2.8.7.1 against this scenario?

Meanwhile, I'll look into the VPN being down making it not possible to authenticate with Google...

@ik8sqi
Copy link

ik8sqi commented Jun 29, 2021 via email

@phw198
Copy link
Owner

phw198 commented Jul 18, 2021

Thanks for the background. So I think we have a couple of test cases:

  1. Internet, no VPN, already authenticated (first reported case): hotfix v2.8.7.1
  2. No internet, no VPN, authentication expired (second reported case): hotfix v2.8.7.3 (includes v2.8.7.1)

📦 I have pulled in the expected fix from #1232 - could you try hotfix v2.8.7.3.zip (see instructions for applying).

Note, Google authentication will expire every hour and OGCS has to refresh the login, which is the second text case.

Please let me know how it goes.

@phw198
Copy link
Owner

phw198 commented Aug 7, 2021

Any feedback on v2.8.7.3 @ik8sqi?

@ik8sqi
Copy link

ik8sqi commented Aug 8, 2021 via email

@ik8sqi
Copy link

ik8sqi commented Aug 10, 2021 via email

@phw198
Copy link
Owner

phw198 commented Sep 18, 2021

Sorry, seemed to have missed this.

📦 New error, additional fix! Please try v2.9.0.8.zip (see instructions for applying) - please ensure you are first running v2.9.0 before you apply this patch.

Please let me know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working right waiting fix confirmation Hotfix available for testing
Projects
None yet
Development

No branches or pull requests

3 participants