Can't remove optional services

[Alexhha]

Hello,

it seems DISABLE_SYSLOG/DISABLE_SSH/DISABLE_CRON doesn't work. I was unable to build base images without those services.

$ git clone https://github.com/phusion/baseimage-docker.git .
$ DISABLE_SYSLOG=1 DISABLE_SSH=1 DISABLE_CRON=1 make NAME=alex/pbi
$ docker build -t alex/pbi:0.9.22 --rm image
Sending build context to Docker daemon 62.98 kB
Step 1/6 : FROM ubuntu:16.04
 ---> 2d696327ab2e
Step 2/6 : MAINTAINER Phusion <[email protected]>
 ---> Running in ed0949279107
...
...
...
Step 5/6 : ENV DEBIAN_FRONTEND "teletype" LANG "en_US.UTF-8" LANGUAGE "en_US:en" LC_ALL "en_US.UTF-8"
 ---> Running in 4d1b27cc5816
 ---> 5f39b42c1198
Removing intermediate container 4d1b27cc5816
Step 6/6 : CMD /sbin/my_init
 ---> Running in 70f2b2b5210e
 ---> eb196e02ff7a
Removing intermediate container 70f2b2b5210e
Successfully built eb196e02ff7a

As you can see from the ps output they are still running

$ docker run -it -d --name pbi-test eb196e02ff7a
8879aaa360c602410cbbea5a0a0188481695aebfad2f981240c12daf9112d257

$ docker exec -it pbi-test ps ax
  PID TTY      STAT   TIME COMMAND
    1 ?        Ss+    0:00 /usr/bin/python3 -u /sbin/my_init
   10 ?        S      0:00 /usr/sbin/syslog-ng --pidfile /var/run/syslog-ng.pid 
   16 ?        S+     0:00 /usr/bin/runsvdir -P /etc/service
   17 ?        Ss     0:00 runsv cron
   18 ?        Ss     0:00 runsv sshd
   19 ?        S      0:00 /usr/sbin/cron -f
   20 ?        Rs+    0:00 ps ax

Did I miss something?

[kingdonb]

According to the docs,

https://github.com/phusion/baseimage-docker#removing-optional-services

this setting should be in ./image/buildconfig (not simply in the environment when you run make.)

Could you try again and let us know if we can close this? Sorry for the delay.

[Theaxiom]

Closing this, if you continue to encounter issues please let us know. Thanks!

[hyperknot]

To be honest, buildconfig contains

export DISABLE_SYSLOG=${DISABLE_SYSLOG:-0}
export DISABLE_SSH=${DISABLE_SSH:-0}
export DISABLE_CRON=${DISABLE_CRON:-0}

So it's trying to read them from environment variables at least. If this doesn't work, we should just change them to 1.

[afraca]

The PR also has unclear wording:
9adbd42

You can user ENV directive in Dockerfile to disable the installation
for some services or change image/buildconfig.

[kingdonb]

That is unclear, "you can user"

Reopening, thanks @afraca

[rdxmb]

To be honest, buildconfig contains

export DISABLE_SYSLOG=${DISABLE_SYSLOG:-0}
export DISABLE_SSH=${DISABLE_SSH:-0}
export DISABLE_CRON=${DISABLE_CRON:-0}

So it's trying to read them from environment variables at least.

No. You have explicitly set them in the docker build - line.
See https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables---build-arg and #482

[kingdonb]

That's right @rdxmb, I'll make a PR to clarify this in the documentation. Thanks for the research.

[kingdonb]

I opened #520 to address this.

[kingdonb]

We can track this documentation issue at #520 now. Thanks for the clarifications!