Add Type::reverseArray()
#3344
Merged
Add Type::reverseArray()
#3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
array-reverse
branch
2 times, most recently
from
a84f5ef to
f146b87
Compare
herndlm
commented
Aug 23, 2024
herndlm
force-pushed
the
array-reverse
branch
2 times, most recently
from
b51481d to
4de50b2
Compare
|
This pull request has been marked as ready for review. |
staabm
reviewed
Aug 24, 2024
|
this one is simple (I think) and should be ready :) sorry for the impatience, I want to work on a follow-up that should improve array_reverse for constant arrays :) |
|
Love it, thanks! |
|
thank you! felt good finally contributing something again, even if it's a simple thing like that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves return type specification of lists and various edge cases with
array_reverse().