UninitializedPropertyRule should be always reported when `checkUninit…

…ializedProperties` is enabled
phpstan · Jan 5, 2025 · ca86412 · ca86412
1 parent 59ccf55
commit ca86412
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/conf/config.level0.neon b/conf/config.level0.neon
@@ -1,10 +1,6 @@
 parameters:
 	customRulesetUsed: false
 
-conditionalTags:
-	PHPStan\Rules\Properties\UninitializedPropertyRule:
-		phpstan.rules.rule: %checkUninitializedProperties%
-
 rules:
 	- PHPStan\Rules\Api\ApiInstanceofRule
 	- PHPStan\Rules\Api\ApiInstanceofTypeRule
@@ -218,9 +214,6 @@ services:
 		tags:
 			- phpstan.rules.rule
 
-	-
-		class: PHPStan\Rules\Properties\UninitializedPropertyRule
-
 	-
 		class: PHPStan\Rules\Properties\WritingToReadOnlyPropertiesRule
 		arguments:
@@ -250,11 +243,6 @@ services:
 		tags:
 			- phpstan.rules.rule
 
-	-
-		class: PHPStan\Reflection\ConstructorsHelper
-		arguments:
-			additionalConstructors: %additionalConstructors%
-
 	-
 		class: PHPStan\Rules\Keywords\RequireFileExistsRule
 		arguments:

diff --git a/conf/config.neon b/conf/config.neon
@@ -211,6 +211,8 @@ conditionalTags:
 		phpstan.rules.rule: %exceptions.check.missingCheckedExceptionInThrows%
 	PHPStan\Rules\Exceptions\MissingCheckedExceptionInPropertyHookThrowsRule:
 		phpstan.rules.rule: %exceptions.check.missingCheckedExceptionInThrows%
+	PHPStan\Rules\Properties\UninitializedPropertyRule:
+		phpstan.rules.rule: %checkUninitializedProperties%
 
 services:
 	-
@@ -734,6 +736,11 @@ services:
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
 
+	-
+		class: PHPStan\Reflection\ConstructorsHelper
+		arguments:
+			additionalConstructors: %additionalConstructors%
+
 	-
 		class: PHPStan\Reflection\RequireExtension\RequireExtendsMethodsClassReflectionExtension
 
@@ -1037,6 +1044,9 @@ services:
 			reportMagicProperties: %reportMagicProperties%
 			checkDynamicProperties: %checkDynamicProperties%
 
+	-
+		class: PHPStan\Rules\Properties\UninitializedPropertyRule
+
 	-
 		class: PHPStan\Rules\Properties\LazyReadWritePropertiesExtensionProvider