MissingTypehintCheck - do not report non-generic object types of gene…

…ric class
phpstan · May 2, 2020 · a3fad5e · a3fad5e
1 parent a7893a8
commit a3fad5e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -135,11 +135,6 @@ parameters:
 			count: 1
 			path: src/Rules/Registry.php
 
-		-
-			message: "#^Method PHPStan\\\\Testing\\\\RuleTestCase\\:\\:getRule\\(\\) return type with generic interface PHPStan\\\\Rules\\\\Rule does not specify its types\\: TNodeType$#"
-			count: 1
-			path: src/Testing/RuleTestCase.php
-
 		-
 			message: "#^Cannot call method getActiveTemplateTypeMap\\(\\) on PHPStan\\\\Reflection\\\\ClassReflection\\|null\\.$#"
 			count: 2

diff --git a/src/Rules/MissingTypehintCheck.php b/src/Rules/MissingTypehintCheck.php
@@ -99,6 +99,9 @@ public function getNonGenericObjectTypesWithGenericClass(Type $type): array
 			if ($type instanceof GenericObjectType) {
 				return $type;
 			}
+			if ($type instanceof TemplateType) {
+				return $type;
+			}
 			if ($type instanceof ObjectType) {
 				$classReflection = $type->getClassReflection();
 				if ($classReflection === null) {

diff --git a/tests/PHPStan/Rules/Methods/data/missing-method-parameter-typehint.php b/tests/PHPStan/Rules/Methods/data/missing-method-parameter-typehint.php
@@ -144,3 +144,17 @@ public function doFoo($it)
 	}
 
 }
+
+class GenericClassInTemplateBound
+{
+
+	/**
+	 * @template T of GenericClass
+	 * @param T $obj
+	 */
+	public function doFoo($obj)
+	{
+
+	}
+
+}