Fix Cannot unset offset 0 on $this when extending SimpleXMLElement

phpstan · Jan 5, 2020 · 3f20c2d · 3f20c2d
1 parent eeae2da
commit 3f20c2d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/src/Type/StaticType.php b/src/Type/StaticType.php
@@ -191,7 +191,7 @@ public function getIterableValueType(): Type
 
 	public function isOffsetAccessible(): TrinaryLogic
 	{
-		return $this->getStaticObjectType()->isInstanceOf(\ArrayAccess::class);
+		return $this->getStaticObjectType()->isOffsetAccessible();
 	}
 
 	public function hasOffsetValueType(Type $offsetType): TrinaryLogic

diff --git a/tests/PHPStan/Rules/Variables/UnsetRuleTest.php b/tests/PHPStan/Rules/Variables/UnsetRuleTest.php
@@ -48,4 +48,9 @@ public function testUnsetRule(): void
 		]);
 	}
 
+	public function testBug2752(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-2752.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Variables/data/bug-2752.php b/tests/PHPStan/Rules/Variables/data/bug-2752.php
@@ -0,0 +1,13 @@
+<?php
+
+namespace Bug2572;
+
+class Foo extends \SimpleXMLElement
+{
+
+	public function doFoo()
+	{
+		unset($this[0]);
+	}
+
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,4 +48,9 @@ public function testUnsetRule(): void @@
     		]);
     	}
+    	public function testBug2752(): void
+    	{
+    		$this->analyse([__DIR__ . '/data/bug-2752.php'], []);
+    	}
     }