Fix variadic parameter after optional

phpstan · Oct 10, 2020 · 287b8b8 · 287b8b8
1 parent 4033321
commit 287b8b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Rules/FunctionDefinitionCheck.php b/src/Rules/FunctionDefinitionCheck.php
@@ -321,7 +321,7 @@ private function checkRequiredParameterAfterOptional(array $parameterNodes): arr
 				throw new \PHPStan\ShouldNotHappenException();
 			}
 			$parameterName = $parameterNode->var->name;
-			if ($optionalParameter !== null && $parameterNode->default === null) {
+			if ($optionalParameter !== null && $parameterNode->default === null && !$parameterNode->variadic) {
 				$errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->nonIgnorable()->build();
 				continue;
 			}

diff --git a/tests/PHPStan/Rules/Functions/data/required-parameter-after-optional.php b/tests/PHPStan/Rules/Functions/data/required-parameter-after-optional.php
@@ -18,3 +18,7 @@ function doBaz(int $foo = 1, $bar): void // not OK
 function doLorem(bool $foo = true, $bar): void // not OK
 {
 }
+
+function doIpsum(bool $foo = true, ...$bar): void // OK
+{
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,3 +18,7 @@ function doBaz(int $foo = 1, $bar): void // not OK @@
     function doLorem(bool $foo = true, $bar): void // not OK
     {
     }
+    function doIpsum(bool $foo = true, ...$bar): void // OK
+    {
+    }