Fix internal error with an unknown interface

phpstan · Aug 12, 2020 · 19fab3f · 19fab3f
1 parent 73f7e73
commit 19fab3f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/Reflection/ClassReflection.php b/src/Reflection/ClassReflection.php
@@ -508,6 +508,15 @@ public function isSubclassOf(string $className): bool
 		}
 	}
 
+	public function implementsInterface(string $className): bool
+	{
+		try {
+			return $this->reflection->implementsInterface($className);
+		} catch (\ReflectionException $e) {
+			return false;
+		}
+	}
+
 	/**
 	 * @return \PHPStan\Reflection\ClassReflection[]
 	 */

diff --git a/src/Rules/Exceptions/CaughtExceptionExistenceRule.php b/src/Rules/Exceptions/CaughtExceptionExistenceRule.php
@@ -52,7 +52,7 @@ public function processNode(Node $node, Scope $scope): array
 			}
 
 			$classReflection = $this->reflectionProvider->getClass($className);
-			if (!$classReflection->isInterface() && !$classReflection->getNativeReflection()->implementsInterface(\Throwable::class)) {
+			if (!$classReflection->isInterface() && !$classReflection->implementsInterface(\Throwable::class)) {
 				$errors[] = RuleErrorBuilder::message(sprintf('Caught class %s is not an exception.', $classReflection->getDisplayName()))->line($class->getLine())->build();
 			}
 

diff --git a/src/Type/ObjectType.php b/src/Type/ObjectType.php
@@ -259,7 +259,7 @@ protected function checkSubclassAcceptability(string $thatClass): TrinaryLogic
 
 		if ($thisReflection->isInterface() && $thatReflection->isInterface()) {
 			return TrinaryLogic::createFromBoolean(
-				$thatReflection->getNativeReflection()->implementsInterface($this->className)
+				$thatReflection->implementsInterface($this->className)
 			);
 		}