-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PHP-CS-Fixer #613
Merged
Merged
Commits on Aug 21, 2024
-
Shim version was used in order to minimise impact of dev dependencies. Config files may look like there are missing classes, but it works.
Configuration menu - View commit details
-
Copy full SHA for 89f7a1b - Browse repository at this point
Copy the full SHA 89f7a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf1f6f3 - Browse repository at this point
Copy the full SHA bf1f6f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for debf00b - Browse repository at this point
Copy the full SHA debf00bView commit details -
Install PHP-CS-Fixer locally under separate dir
This is required because Prophecy supports PHP 7.2+ while Fixer requires PHP >=7.4, so it's failing in the CI.
Configuration menu - View commit details
-
Copy full SHA for c4df9f5 - Browse repository at this point
Copy the full SHA c4df9f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c464e7 - Browse repository at this point
Copy the full SHA 8c464e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e29c4 - Browse repository at this point
Copy the full SHA 45e29c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 940453f - Browse repository at this point
Copy the full SHA 940453fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72985b1 - Browse repository at this point
Copy the full SHA 72985b1View commit details -
Install PHP-CS-Fixer as dev dependency, but remove it before running …
…tests in the CI Fixer is needed only in dedicated job, which runs on PHP 8.2 so dependencies can be resolved. For running tests it;s not required at all, so even if it's not compatible only with 7.2 and 7.3 we can remove it for any PHP version in the tests' matrix.
Configuration menu - View commit details
-
Copy full SHA for 4de2df7 - Browse repository at this point
Copy the full SHA 4de2df7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfdb2e7 - Browse repository at this point
Copy the full SHA bfdb2e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b771678 - Browse repository at this point
Copy the full SHA b771678View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0459323 - Browse repository at this point
Copy the full SHA 0459323View commit details -
Disable
trailing_comma_in_multiline
ruleSince PHP 7.2-7.4 is supported we can't use trailing commas in arguments, parameters and match. Enabling it only for arrays is against current coding standard used in the project.
Configuration menu - View commit details
-
Copy full SHA for f4e8157 - Browse repository at this point
Copy the full SHA f4e8157View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7df023 - Browse repository at this point
Copy the full SHA c7df023View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.