Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PHP-CS-Fixer #613

Merged
merged 14 commits into from
Aug 27, 2024
Merged

Commits on Aug 21, 2024

  1. Introduce PHP-CS-Fixer

    Shim version was used in order to minimise impact of dev dependencies. Config files may look like there are missing classes, but it works.
    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    89f7a1b View commit details
    Browse the repository at this point in the history
  2. Run PHP-CS-Fixer in CI

    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bf1f6f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    debf00b View commit details
    Browse the repository at this point in the history
  4. Install PHP-CS-Fixer locally under separate dir

    This is required because Prophecy supports PHP 7.2+ while Fixer requires PHP >=7.4, so it's failing in the CI.
    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c4df9f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8c464e7 View commit details
    Browse the repository at this point in the history
  6. Do not install dev-tools in CI

    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    45e29c4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    940453f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    72985b1 View commit details
    Browse the repository at this point in the history
  9. Install PHP-CS-Fixer as dev dependency, but remove it before running …

    …tests in the CI
    
    Fixer is needed only in dedicated job, which runs on PHP 8.2 so dependencies can be resolved. For running tests it;s not required at all, so even if it's not compatible only with 7.2 and 7.3 we can remove it for any PHP version in the tests' matrix.
    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4de2df7 View commit details
    Browse the repository at this point in the history
  10. Bump actions/checkout to v4

    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bfdb2e7 View commit details
    Browse the repository at this point in the history
  11. Fix coding-standards job

    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b771678 View commit details
    Browse the repository at this point in the history
  12. Apply CS fixes

    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0459323 View commit details
    Browse the repository at this point in the history
  13. Disable trailing_comma_in_multiline rule

    Since PHP 7.2-7.4 is supported we can't use trailing commas in arguments, parameters and match. Enabling it only for arrays is against current coding standard used in the project.
    Wirone committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f4e8157 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    c7df023 View commit details
    Browse the repository at this point in the history