Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added healthecks #249

Closed
wants to merge 1 commit into from
Closed

Conversation

fruitl00p
Copy link

This seems a minor issue, but both images should now have the ability to check their own health. (by fetching the LICENSE. This could also be extended to a real PHP request to make sure all the requirements are still there (i.e. correctly configured PHP, MySQL et al)

But this at least should fix #182

This does increase the docker required version to 1.12 (but that is quite old so shouldnt be a problem)

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@J0WI
Copy link
Contributor

J0WI commented Nov 10, 2019

This wont' work for FPM variants.

@fruitl00p
Copy link
Author

@J0WI could the inclusion of https://github.com/renatomefi/php-fpm-healthcheck be of any help resolving this? Having the PHP-FPM statuspage available and exportable using the aforementioned script seems like a good way to have a healthcheck ánd export some type of stats?

@J0WI
Copy link
Contributor

J0WI commented Nov 11, 2019

You can simply use the cgi-fcgi command, but I generally agree with docker-library/cassandra#76 (comment)

@fruitl00p
Copy link
Author

@J0WI I understand the position as mentioned in the docker-library/cassandra#76 (comment) but as this is the phpmyadmin container it would seem that it is indeed the correct place to introduce the healthcheck as its not the platform image as cassandra might be classified as...

Anyway, do with this PR as you see fit... I'll leave this entirely up to your best judgement...

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 11, 2020
@stale
Copy link

stale bot commented Mar 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 11, 2020
@stale
Copy link

stale bot commented May 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 10, 2020
@stale stale bot closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

health check
3 participants