[FEATURE] Domain model and repository for subscribers #223
Conversation
oliverklee
force-pushed
the
feature/subscriber
branch
from
c6ccb99 to
8294c23
Compare
| private $bounceCount = 0; | ||
|
|
||
| /** | ||
| * Note: The uniqueness of this column will not be enforced as long as we use the old DB schema, |
There was a problem hiding this comment.
Will not be enforced by the database engine, or will not be enforced at all (is there not application-level verification)?
There was a problem hiding this comment.
It currently will not be enforced at all (as this only influences that generated DB schema).
When we let Doctrine generate the DB schema for us, then this will be enforced (at the DB level).
There was a problem hiding this comment.
AFAIK, Doctrine only enforces this at the DB level, not at application level.
There was a problem hiding this comment.
(I havent't checked whether there are any additional checks in phpList 3 for this, though.)
There was a problem hiding this comment.
Generating duplicate IDs should be impossible using the HMAC system implemented, as I understand it. I think it's enough to rely on phpList3 to validate during generation and DB schema to enforce later when doctrine is used to generate it.
There was a problem hiding this comment.
No, it's not impossible, just very unlikely that two autogenerated UUID are the same (both in phpList 3 and 4). phpList 3 also does not check for duplicate UUIDs when generating them - it just hopes for the best (fingers crossed).
And it's not HMAC - just a bunch of random bytes.
There was a problem hiding this comment.
(At least in the UUID-generating piece of code which I found. Maybe there are more than one.)
There was a problem hiding this comment.
No, it's not impossible, just very unlikely that two autogenerated UUID are the same (both in phpList 3 and 4). phpList 3 also does not check for duplicate UUIDs when generating them - it just hopes for the best (fingers crossed).
And it's not HMAC - just a bunch of random bytes.
@michield Please can you clarify the following: does phpList 3 rely on database-level enforcement of UUID uniqueness at the time that the UUIDs are generated?
No description provided.