[CLEANUP] Add an Environment class #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
cleanup/environment-interface
branch
from
7c99cb6 to
d00471c
Compare
39 tasks
This resolves a circular dependency between Bootstrap and ApplicationKernel. Also unify the terminology from "application context" to "environment" to be closes to Symfony conventions.
oliverklee
force-pushed
the
cleanup/environment-interface
branch
from
d00471c to
0ec8793
Compare
samtuke
approved these changes
Jul 29, 2017
|
It seems that there are still some references to setApplicationContext(), and that these are now causing the builds to fail in the other modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a circular dependency between Bootstrap and ApplicationKernel.
Also unify the terminology from "application context" to "environment" to
be closer to Symfony conventions.