Support variadic parameters – take 2 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, PhD does not support variadic parameters. Instead the manual follows the convention to use `...` as parameter name, which is then rendered as `$...` in the docs. However, as of PHP 5.6.0 variadic parameters are supported using the syntax `...$args`; therefore, we are going to support this notation for PhD. While DocBook supports a `<varargs>` element, this cannot be used in combination with named parameters. Therefore, we use the `rep` attribute of the `<methodparam>` element to designate variadic parameters.
|
Ugh, the PDF renderer seems to rely on PECL/haru, which is abandoned; latest release almost 8 years ago, and unlikely to be compatible with PHP 7. PS: and there is also php/web-php@beaf588 |
|
Also, if we go this way, should |
This was referenced Oct 13, 2020
nikic
reviewed
Oct 29, 2020
This was referenced Oct 31, 2020
What's the problem there? |
|
That should be solved with php/web-php#349. |
nikic
reviewed
Nov 2, 2020
| $this->params["ellipsis"] = '...'; | ||
| } else { | ||
| $this->params["ellipsis"] = ''; | ||
| } |
There was a problem hiding this comment.
Why do we set params["ellipsis"] here rather than handling it directly in format_methodparam_parameter, like the role is?
There was a problem hiding this comment.
role="reference" is an attribute of <parameter>, but rep="repeat" is an attribute of <methodparam>.
nikic
approved these changes
Nov 2, 2020
|
Applied as d59932c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, PhD does not support variadic parameters. Instead the manual
follows the convention to use
...as parameter name, which is thenrendered as
$...in the docs. However, as of PHP 5.6.0 variadicparameters are supported using the syntax
...$args; therefore, we aregoing to support this notation for PhD.
While DocBook supports a
<varargs>element, this cannot be used incombination with named parameters. Therefore, we use the
repattribute of the
<methodparam>element to designate variadicparameters.
What I don't like about this solution is the semantic mismatch. Consider, e.g.
array_merge(array ...$arrays); it is not actually$arrayswhich is repeatable, but rather$array. Maybe I'm too nit-picky here.TODO: