Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] fix php/doc-en#3936 ([PHP 8.4] Add new constants and tokens from the tokenizer) #194

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

o0h
Copy link
Contributor

@o0h o0h commented Nov 24, 2024

Issue

Refs

  • ターゲットとしているPRには appendices/migration84/constants.xml の変更も含まれているが、jaへは ↓で反映済み

<sect2 xml:id="migration84.constants.tokenizer">
<title>Tokenizer</title>
<simplelist>
<member>
<constant>T_PUBLIC_SET</constant>
</member>
<member>
<constant>T_PROTECTED_SET</constant>
</member>
<member>
<constant>T_PRIVATE_SET</constant>
</member>
</simplelist>
</sect2>


追加されたのは、Property Hooksに伴って追加された3つのトークン
image

@o0h o0h changed the title [WIP] fix php/doc-en#3936 ([PHP 8.4] Add new constants and tokens from the tokenizer) [WIP][PHP 8.4] fix php/doc-en#3936 ([PHP 8.4] Add new constants and tokens from the tokenizer) Nov 24, 2024
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: 270a871223343be9280a3e8a133a5467a3e82908 Maintainer: hirokawa Status: ready -->
<!-- EN-Revision: 8a6397d39aefd23c61d64aa4e9af919772541e2a Maintainer: hirokawa Status: ready -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<entry><constant>T_PRIVATE_SET</constant></entry>
<entry>private(set)</entry>
<entry>
プロパティフック (PHP 8.4.0 以降で利用可能)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

機能のページへリンクがないのはenも同様

Copy link
Collaborator

@KentarouTakeda KentarouTakeda Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、作成時点でリンク先が用意されてなかった、が理由だと思うので、そのうち原文が更新される気がします😇

@o0h o0h marked this pull request as ready for review November 24, 2024 16:52
@o0h o0h changed the title [WIP][PHP 8.4] fix php/doc-en#3936 ([PHP 8.4] Add new constants and tokens from the tokenizer) [PHP 8.4] fix php/doc-en#3936 ([PHP 8.4] Add new constants and tokens from the tokenizer) Nov 24, 2024
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@KentarouTakeda KentarouTakeda merged commit 9169d2f into php:master Nov 25, 2024
1 check passed
o0h added a commit to o0h/php-doc-ja that referenced this pull request Nov 25, 2024
KentarouTakeda pushed a commit that referenced this pull request Nov 25, 2024
* [WIP] work on php/doc-en#4063

* #191 Insert original content

ref: php/doc-en@72b70d7

* #191 Translate

* #194 Fix element position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants