Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] fix php/doc-en#4122 (PHP 8.4: Flushing headers without a body will now succeed) #188

Merged
merged 4 commits into from
Nov 24, 2024
+23 −1
Merged

[PHP 8.4] fix php/doc-en#4122 (PHP 8.4: Flushing headers without a body will now succeed) #188

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96aa519
[WIP] fix php/doc-en#4122
o0h Nov 24, 2024
89548e9
#188 Insert original content
o0h Nov 24, 2024
1d0bf1c
#188 Translate
o0h Nov 24, 2024
e5bd725
`EN-Revision`の更新
KentarouTakeda Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion reference/outcontrol/functions/flush.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: 91ab4f5f898023b0eed0e642e1482ac11f749d20 Maintainer: hirokawa Status: ready -->
<!-- EN-Revision: bac9d6a54fae363b3cc337bda924a76ff47e8851 Maintainer: hirokawa Status: ready -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KentarouTakeda (後学のために質問させてください！

ココに記載するのって、reference/outcontrol/functions/flush.xml の最終コミットかな？と思っていたのですが
php/doc-en@77ae333
ではなくて
php/doc-en@bac9d6a
であってますか？ 💡

cf: 手元で生成した revcheck.html のキャプ
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみませんでした！はい、合ってます、つまり私の修正ミスです。

修正しました。非常に助かりました！！！

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、完璧に覚えました！
次回からは自分の作業に含められそうです 👍

<!-- CREDITS: shimooka -->
<refentry xmlns="http://docbook.org/ns/docbook" xml:id="function.flush">
<refnamediv>
Expand Down Expand Up @@ -56,6 +56,28 @@
&return.void;
</para>
</refsect1>

<refsect1 role="changelog">
&reftitle.changelog;
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
FastCGI 利用時に、本文なしでヘッダをフラッシュできるようになりました。
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</refsect1>

<refsect1 role="seealso">
&reftitle.seealso;
Expand Down