Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ...$args name to sprintf #55

Closed
wants to merge 1 commit into from
Closed

Add ...$args name to sprintf #55

wants to merge 1 commit into from

Conversation

simPod
Copy link

@simPod simPod commented Mar 6, 2020

No description provided.

@cmb69
Copy link
Member

cmb69 commented Mar 6, 2020

Did you check how that would render? I presume that comes out as $...args instead of the PHP syntax conforming ...$args. If that's the case, PhD should be modified first, before making these changes in the manual (and we certainly would want to change all occurances at once).

@simPod
Copy link
Author

simPod commented Mar 6, 2020

Thank you for feedback, will look into it

@simPod simPod mentioned this pull request Mar 7, 2020
Open
@simPod simPod mentioned this pull request Sep 3, 2020
Closed
@cmb69
Copy link
Member

cmb69 commented Nov 2, 2020

This is now handled somewhat differently, but still this PR can be closed.

@cmb69 cmb69 closed this Nov 2, 2020
@cmb69 cmb69 removed the variadics label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simPod @cmb69