Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special chars with custom control mappings #283

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

bit-willi
Copy link
Contributor

Allow usage of special chars with custom control mappings

Closes #282

allow usage of special chars with custom control mappings
@AydinHassan
Copy link
Member

thanks @bit-willi - can you add a test for it? You can just copy testAddCustomControlMapping and also copy the asset file testAddCustomControlMapping.txt - you would just have to change the mapping and terminal mock.

@AydinHassan AydinHassan merged commit b1cc7a3 into php-school:master Oct 23, 2024
11 checks passed
@AydinHassan
Copy link
Member

thank you @bit-willi :)

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (835c28e) to head (5a6cec9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #283   +/-   ##
=========================================
  Coverage     93.46%   93.47%           
- Complexity      656      658    +2     
=========================================
  Files            38       38           
  Lines          2021     2024    +3     
=========================================
+ Hits           1889     1892    +3     
  Misses          132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle control chars in menus
2 participants