do not trim strings containing binary data

php-sap · Jan 24, 2019 · 68fc41c · 68fc41c
1 parent 309f169
commit 68fc41c
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/SapRfcFunction.php b/src/SapRfcFunction.php
@@ -51,9 +51,7 @@ public function __destruct()
     /**
      * Execute the prepared function call.
      * @return array
-     * @throws \phpsap\exceptions\ConnectionFailedException
      * @throws \phpsap\exceptions\FunctionCallException
-     * @throws \phpsap\exceptions\UnknownFunctionException
      */
     protected function execute()
     {
@@ -113,11 +111,9 @@ protected function trimStrings($return)
     protected function rTrim($string)
     {
         /**
-         * Do not trim strings containing line breaks.
+         * Do not trim strings containing non-printable characters.
          */
-        if (strpos($string, "\n") !== false
-            || strpos($string, "\r\n") !== false
-        ) {
+        if (!ctype_print($string)) {
             return $string;
         }
         return rtrim($string);