[Hotfix] Fix Phar building #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/69-fix-phar-building
branch
4 times, most recently
from
2330dc0 to
327a273
Compare
|
Argh... there is nothing in this PR which could cause the failures on PHP 5.3 - 5.5, so I just did a test (re)build of I've gone through everything in the script to try and figure out what is causing it, but so far haven't found the cause yet.
|
|
@grogy Bump... |
|
FYI: I will rebase this PR once PR #71 has been merged. |
Box 2 is no longer maintained and will not be made compatible with more recent PHP versions. Refs: * https://github.com/box-project/box/blob/master/UPGRADE.md#from-27-to-30 * https://github.com/box-project/box/blob/master/doc/configuration.md
For the time being, until box-project/box#567 has been fixed: 1. Disable the addition of the requirement checker from Box as the version included in the last release of Box is not compatible with PHP 8.1. 2. Change the PHP version used to generate the Phar to PHP 8.0 to get round the problem the PHP compactor has with attributes. Note: the generated Phar file should still be compatible with all supported PHP versions.
jrfnl
force-pushed
the
feature/69-fix-phar-building
branch
from
327a273 to
daf0dfa
Compare
|
Rebased now #71 has been merged. |
|
Thank you, I tried created PHAR with 7.4 server and works ok |
The Phar is also being tested against all supported PHP versions in the |
jrfnl
added a commit
that referenced
this pull request
Jun 27, 2022
The box project has released Box 4.0.0 (and 4.0.1). Most notable changes: * New minimum PHP version of PHP 8.1. * The sodium extension has become a requirement. * The requirements checker now has a minimum PHP version of PHP 7.2.4. We already disabled the requirements checker previously due to PHP 8.1 incompatibilities (PR #70), I've not added a comment to document not to turn it on again as that would make the Parallel Lint PHAR incompatible with PHP < 7.2. Refs: https://github.com/box-project/box/releases/tag/4.0.0
jrfnl
added a commit
that referenced
this pull request
Jun 27, 2022
The box project has released Box 4.0.0 (and 4.0.1). Most notable changes: * New minimum PHP version of PHP 8.1. * The sodium extension has become a requirement. * The requirements checker now has a minimum PHP version of PHP 7.2.4. We already disabled the requirements checker previously due to PHP 8.1 incompatibilities (PR #70), I've not added a comment to document not to turn it on again as that would make the Parallel Lint PHAR incompatible with PHP < 7.2. Refs: https://github.com/box-project/box/releases/tag/4.0.0
This was referenced Jun 27, 2022
grogy
pushed a commit
that referenced
this pull request
Jul 25, 2022
The box project has released Box 4.0.0 (and 4.0.1). Most notable changes: * New minimum PHP version of PHP 8.1. * The sodium extension has become a requirement. * The requirements checker now has a minimum PHP version of PHP 7.2.4. We already disabled the requirements checker previously due to PHP 8.1 incompatibilities (PR #70), I've not added a comment to document not to turn it on again as that would make the Parallel Lint PHAR incompatible with PHP < 7.2. Refs: https://github.com/box-project/box/releases/tag/4.0.0
grogy
pushed a commit
that referenced
this pull request
Jul 25, 2022
The box project has released Box 4.0.0 (and 4.0.1). Most notable changes: * New minimum PHP version of PHP 8.1. * The sodium extension has become a requirement. * The requirements checker now has a minimum PHP version of PHP 7.2.4. We already disabled the requirements checker previously due to PHP 8.1 incompatibilities (PR #70), I've not added a comment to document not to turn it on again as that would make the Parallel Lint PHAR incompatible with PHP < 7.2. Refs: https://github.com/box-project/box/releases/tag/4.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Box 3 for Phar generation
Box 2 is no longer maintained and will not be made compatible with more recent PHP versions.
Refs:
PHP 8.1: fix Phar building
For the time being, until box-project/box#567 has been fixed:
Note: the generated Phar file should still be compatible with all supported PHP versions.
Fixes #69
Closes #39
Closes #36
@grogy A release with a Phar generated after this fix has been merged would be appreciated as anyone currently using this tool to lint their files against PHP 8.1 (in CI or otherwise) is affected by this issue.