Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to add the --show-deprecated option to help/docs #81

Closed
stronk7 opened this issue Dec 19, 2021 · 3 comments · Fixed by #84
Closed

Suggestion to add the --show-deprecated option to help/docs #81

stronk7 opened this issue Dec 19, 2021 · 3 comments · Fixed by #84
Labels
Type: documentation
Milestone
1.3.2

Comments

@stronk7
Copy link

stronk7 commented Dec 19, 2021 •
edited
Loading

Hi,

unless I'm missing something, the --show-deprecated option is not documented in readme / cli help. And it really would be useful to have it present there. It took some time to me to see if it was supported or no when it's important enough, IMO.

For your consideration, thanks for the estupendo linter!

Ciao :-)
@jrfnl
Copy link
Collaborator

jrfnl commented Dec 19, 2021

Looks like it also doesn't show when using the -h argument on the command-line.

@jrfnl jrfnl mentioned this issue Feb 17, 2022
Merged
@jrfnl
Copy link
Collaborator

jrfnl commented Feb 17, 2022

PR #84 should address this.

@jrfnl jrfnl added this to the 1.x Next milestone Feb 17, 2022
@jrfnl
Copy link
Collaborator

jrfnl commented Feb 17, 2022

For the record, the --show-deprecated option was added in JakubOnderka/PHP-Parallel-Lint#94

@grogy grogy closed this as completed in #84 Feb 17, 2022
jrfnl added a commit to Yoast/yoastcs that referenced this issue Feb 17, 2022
@jrfnl
README: update suggested linting command
8110f4e 
The `--show-deprecated` option was added to PHP Parallel Lint some years ago, but never documented, so I never knew it existed.

Enabling this option allows for deprecations which can be detected at compile time to be shown (in contrast to deprecations which can only be detected at run-time).

Refs:
* php-parallel-lint/PHP-Parallel-Lint#81
* JakubOnderka/PHP-Parallel-Lint#94
@jrfnl jrfnl mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: documentation
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Docs: show all options in help and README php-parallel-lint/PHP-Parallel-Lint
2 participants
@stronk7 @jrfnl