Use PHP-Code-Style 2.0 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Composer: require `php-parallel-lint/php-code-style` at 2.0 or higher. * Composer: remove the requirement for PHPCS. This will now be inherited from the code style repo.
* Scan all PHP files, not just the file in `src` for improved consistency across the code base, but exclude the `vendor` and the `build` (code coverage) directories. * Enable parallel scanning for faster results. * Use the ruleset from PHP-Code-Style by name. * Set the `testVersion` for use with PHPCompatibility. * Exclude the `LineLength` sniff for the tests. * Include minimal documentation in the ruleset.
Fix up the issues which will be flagged by PHP-Code-Style 2.0 and explicitly ignore a couple of (non-)issues. Includes no longer allowing warnings in the GH Actions build.
Rewrite the method to use predefined token lists. Includes removing the PHPCS ruleset tweak put in place in an earlier commit. Fixes 11
jrfnl
force-pushed
the
feature/update-code-style
branch
from
4560028 to
378d0b8
Compare
|
Thank you Big plus points for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS: use PHP-Code-Style 2.0
php-parallel-lint/php-code-styleat 2.0 or higher.Ruleset: various tweaks for PHP-Code-Style 2.0
srcfor improved consistency across the code base, but exclude thevendorand thebuild(code coverage) directories.testVersionfor use with PHPCompatibility.LineLengthsniff for the tests.CS: various minor fixes
Fix up the issues which will be flagged by PHP-Code-Style 2.0 and explicitly ignore a couple of (non-)issues.
Includes no longer allowing warnings in the GH Actions build.
Highlighter::getTokenType(): refactor to lower complexity
Rewrite the method to use predefined token lists.
Includes removing the PHPCS ruleset tweak put in place in an earlier commit.
Fixes #11