update to gettext/gettext 5.1.0

php-gettext · Nov 11, 2019 · 31e87a7 · 31e87a7
1 parent ac173ef
commit 31e87a7
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
     "require": {
         "php": "^7.2",
         "nikic/php-parser": "^4.2",
-        "gettext/gettext": "^5.0"
+        "gettext/gettext": "^5.1"
     },
     "require-dev": {
         "phpunit/phpunit": "^8.0",

diff --git a/tests/PhpScannerTest.php b/tests/PhpScannerTest.php
@@ -2,6 +2,7 @@
 
 namespace Gettext\Tests;
 
+use Exception;
 use Gettext\Scanner\PhpScanner;
 use Gettext\Translations;
 use PHPUnit\Framework\TestCase;
@@ -35,4 +36,27 @@ public function testPhpCodeScanner()
         $this->assertCount(4, $domain2);
         $this->assertCount(1, $domain3);
     }
+
+    public function testInvalidFunction()
+    {
+        $this->expectException(Exception::class);
+
+        $scanner = new PhpScanner(Translations::create('messages'));
+        $scanner->scanString('<?php __(ucfirst("invalid function"));', 'file.php');
+
+        list($translations) = array_values($scanner->getTranslations());
+
+        $this->assertCount(0, $translations);
+    }
+
+    public function testIgnoredInvalidFunction()
+    {
+        $scanner = new PhpScanner(Translations::create('messages'));
+        $scanner->ignoreInvalidFunctions();
+        $scanner->scanString('<?php __(ucfirst("invalid function"));', 'file.php');
+
+        list($translations) = array_values($scanner->getTranslations());
+
+        $this->assertCount(0, $translations);
+    }
 }