Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Twig extractor support #71

Merged
merged 6 commits into from
Apr 6, 2015
Merged

Conversation

assembledadam
Copy link
Contributor

Note I haven't added tests - not sure how I should handle that given the required libraries are only suggested in composer (means automated testing will fail unless it also pulls down the suggestions).

Happy to add tests if this isn't a problem.

Adam McCann added 2 commits March 20, 2015 11:56
Updated composer with Twig extractor suggestion + fixed intent by tab instead of 4 spaces (PSR-4 standard)
@oscarotero
Copy link
Member

Hi, thanks for your great job!
Currently there is another extractor that require third party libraries (Blade extractor) and had no tests. I've made a commit adding tests for this case, using the "require-dev" property to install it only in development contexts. I guess this is the right way to do.

@jtreminio
Copy link

@oscarotero merging this PR would be great!

@assembledadam
Copy link
Contributor Author

Aha - no problem then, I will add tests as soon as I can.

@oscarotero
Copy link
Member

Great, once the tests are added, I will merge the PR

exnor added 4 commits April 5, 2015 22:08
@assembledadam
Copy link
Contributor Author

Added tests :)

oscarotero added a commit that referenced this pull request Apr 6, 2015
Added Twig extractor support
@oscarotero oscarotero merged commit f11a520 into php-gettext:master Apr 6, 2015
@oscarotero
Copy link
Member

Thank you 👍

@assembledadam
Copy link
Contributor Author

Oh, also note (for anyone finding this via Google or whatever) the Twig i18n extension does not appear to support gettext context, hence this not being in the tests above.

From what I can tell this is something Drupal have added to their framework, but did not add to the Twig source. I may end up adding it in due course - if so ill update this thread.

@jtreminio
Copy link

@Exnor I actually made Twig work 100% with this project. It's actually a very simple fix, and everything seems to be working. I'll be releasing a Twig extension soon.

@assembledadam
Copy link
Contributor Author

@jtreminio great!

@oscarotero oscarotero mentioned this pull request Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants