-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Twig extractor support #71
Conversation
Updated composer with Twig extractor suggestion + fixed intent by tab instead of 4 spaces (PSR-4 standard)
Hi, thanks for your great job! |
@oscarotero merging this PR would be great! |
Aha - no problem then, I will add tests as soon as I can. |
Great, once the tests are added, I will merge the PR |
Merge remote-tracking branch 'upstream/master'
Added tests :) |
Added Twig extractor support
Thank you 👍 |
Oh, also note (for anyone finding this via Google or whatever) the Twig i18n extension does not appear to support gettext context, hence this not being in the tests above. From what I can tell this is something Drupal have added to their framework, but did not add to the Twig source. I may end up adding it in due course - if so ill update this thread. |
@Exnor I actually made Twig work 100% with this project. It's actually a very simple fix, and everything seems to be working. I'll be releasing a Twig extension soon. |
@jtreminio great! |
Note I haven't added tests - not sure how I should handle that given the required libraries are only suggested in composer (means automated testing will fail unless it also pulls down the suggestions).
Happy to add tests if this isn't a problem.