PHP 8.1 compatibility #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by setting #[ReturnTypeWillChange] for JsonSerializable and IteratorAggregate interface implementations
|
Eventually @oscarotero could have a look and release a new patched version? I think that anyone who wants to use PHP 8.1 and converts warnings to exceptions during testing would greatly appreciate it as it currently breaks unit tests ^^ |
|
sorry for the delay. Thank you! |
|
Hi, Thanks fo this patch. For information, version 5.6.1 has not been published to packagist. Regards |
|
@cedric-anne Thanks for advising. It's fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting
#[\ReturnTypeWillChange]forJsonSerializableandIteratorAggregateinterface implementations the warnings are fixed.As
#was previously only a sign for a comment, its backwards compatible to older PHP versions.Closes #277 (PHP 8.1 compatibility: warnings about JsonSerializable compatibility)