Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check Po file content on bigendian #159

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

remicollet
Copy link
Contributor

As all Po reference files are LittleEndian

@bowlofeggs
Copy link

+1

@oscarotero
Copy link
Member

oscarotero commented Feb 26, 2018

Could this be fixed using a function like this? http://shiplu.mokadd.im/95/convert-little-endian-to-big-endian-in-php-or-vice-versa/
If so, there's no need to skip tests.

@remicollet
Copy link
Contributor Author

The problem is about reference files provided in the tests/assert directory.

If you don't want to skip this tests, you have to provide both versions (little and big endian)

@oscarotero
Copy link
Member

Sorry, I don't understand. I've no experience with little/big endian.
What I mean is to convert the string from little-endian to big-endian before the assertion, using the function linked above. If this does not solve the problem, I can merge it anyway, but I'd preffer not to skip tests if it's possible.

@remicollet
Copy link
Contributor Author

$ file tests/assets/po/Mo.mo
tests/assets/po/Mo.mo: GNU message catalog (little endian), revision 0.0, 4 messages

So you cannot compare file generated by the library (which will be Big Endian), and reference file which is Little Endian.

@oscarotero oscarotero merged commit 99e1abc into php-gettext:master Feb 26, 2018
@bowlofeggs
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants