Make csv options configurable via $options

[Zae]

Make csv options configurable via $options, defaults are set to the PHP defaults.

Translations::fromCsvFile($destination, ['delimiter' => ';']);

$translations->toCsvFile(
    $pathinfo['dirname'] . '/' . $pathinfo['filename'] . '.csv',
    [
        'includeHeaders' => true,
        'delimiter' => ';'
    ]
);

[Zae]

I see the tests fail because of incompatibilty with the parameter count in older versions of PHP, any suggestions to fix this cleanly?

[oscarotero]

A way to make it compatible with php 5.5 is using version_compare and execute the function without the last argument if the php version is lower than 5.5.4

[Zae]

Yes, I was thinking about that, but thought that might be weird that some options won't be available and the code might get a little sloppy with version_compare's all over the place.

I'll have a little think about it and update the PR later :)

[Zae]

I added a function that wraps the csv functions with backward compatible versions.

[oscarotero]

Thank you 👍

[oscarotero]

Ok, I've changed a bit your code. The same options have been extended to csvDictionary (extractor and generator) and, althought there's support for the escape_char argument in fgetcsv since php 5.3, I think is better to use the same version than fputcsv, in order to maintain the same support in csv generation and extraction.

[Zae]

Sounds reasonable, I wasn't using the CsvDictionary so didn't think about adding it there, good that you did :)

When do you think you will tag a new release?

[oscarotero]

v4.4.0 released