CSV Generator and Extractor #106
Conversation
CSV files are a good format for customers and non-developers. To exchange translations with them a csv generator and extractor have been introduced.
|
PHP 5.3 go and get your pension! :/ |
|
It's not always that easy to move projects to newer PHP versions, in particular the big and widely used ones |
|
I know and that's okay. Old projects never realy switch to newer packages. Feel free to drop some support sometimes with a new major release or so ;) Hope you merge it :) I really like to use it in some projects and have a better base for customers. They know Excel so they can help translating now ;) |
| } | ||
|
|
||
| $tmpFile = tempnam(sys_get_temp_dir(), 'gettext_'); | ||
| $handle = fopen($tmpFile, 'w'); |
There was a problem hiding this comment.
Why not use fopen('php://temp', 'w')? Seems more optimized than creating a real file in disk.
There was a problem hiding this comment.
I don't know if others use that stream already so a file is a fail-safe method.
If php://temp will create a new file or stream with every fopen then this is fail-safe as well.
Anyway I change it to the "php://temp" now.
|
I read the comments and changed the code. Hope to see a merge soon :) |
|
Thanks for your contribution 👍 |
CSV files are a good format for customers and non-developers.
To exchange translations with them a csv generator and extractor have been introduced.