-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP functions prefixed with a slash are being ignored #284
Comments
This is in Gettext 4, right? I'm not working on maintaining this version (not enough time) but accept PR. If you want to work on that, I guess this can be fixed somewhere here: https://github.com/php-gettext/Gettext/blob/4.x/src/Utils/PhpFunctionsScanner.php#L117 |
2 tasks
It might be good to know that this seems to work well on PHP 7.4, but it goes wrong in PHP 8: |
remcotolsma
added a commit
to remcotolsma/Gettext
that referenced
this issue
Dec 7, 2022
See following issues for more details: - php-gettext#284 - wp-cli/i18n-command#344
oscarotero
added a commit
that referenced
this issue
Dec 7, 2022
Handle PHP 8 `T_NAME_FULLY_QUALIFIED` to fix issue #284
Fixed and released in v4.8.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I thought this issue was directly related to
wp-cli
and so I posted the original message there: wp-cli/i18n-command#344Basically when prefixing a PHP i18n with a slash it gets ignored.
e.g.
The text was updated successfully, but these errors were encountered: