Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VueJS extractor issue #187

Closed
MarekGogol opened this issue Aug 1, 2018 · 1 comment
Closed

VueJS extractor issue #187

MarekGogol opened this issue Aug 1, 2018 · 1 comment

Comments

@MarekGogol
Copy link
Contributor

MarekGogol commented Aug 1, 2018

Hello,

Thank you for this awesome package. But I found one bug in VueJs extractor.

If function returns directly translation without variable or other constructor, then extractor does not work properly.

version: v4.6.0

methods: {
        //Work
        myVueMethod(){
            var a = _('my translate 1');

            return a;
        },
        //Work
        myVueMethod2(){
            return this._('my translate 2');
        },
        //Does not work
        myVueMethod3(){
            return _('my translate 3');
        },
        //Work
        myVueMethod4(){
            return 'my test' + _('my translate 4');
        },

Regards, Marek.

oscarotero added a commit that referenced this issue Aug 27, 2018
@oscarotero
Copy link
Member

Thanks for the feedback. It should be fixed in v4.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants