Skip to content

Commit

Permalink
Merge pull request #280 from tvdijen/patch-1
Browse files Browse the repository at this point in the history
Suppress deprecation error on PHP 8.1
  • Loading branch information
oscarotero authored Feb 17, 2022
2 parents bbeb8f4 + 1f70893 commit 3e7460f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/Translations.php
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ public function __clone()
*
* @return Translation
*/
#[\ReturnTypeWillChange]
public function offsetSet($index, $value)
{
if (!($value instanceof Translation)) {
Expand Down

3 comments on commit 3e7460f

@tvdijen
Copy link

@tvdijen tvdijen commented on 3e7460f Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oscarotero! Would it be possible for you to tag a new 4.8.x release so we can have this change in a stable release?

@oscarotero
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry for being late.

@tvdijen
Copy link

@tvdijen tvdijen commented on 3e7460f Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem at all! Thanks for your efforts

Please sign in to comment.