hotfix: make the filename mandatory on scan strings

php-gettext · Nov 4, 2019 · 20059a7 · 20059a7
1 parent 817ab56
commit 20059a7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Scanner/CodeScanner.php b/src/Scanner/CodeScanner.php
@@ -51,7 +51,7 @@ public function getFunctions(): array
         return $this->functions;
     }
 
-    public function scanString(string $string, string $filename = null): void
+    public function scanString(string $string, string $filename): void
     {
         $functionsScanner = $this->getFunctionsScanner();
         $functions = $functionsScanner->scan($string, $filename);

diff --git a/src/Scanner/FunctionsScannerInterface.php b/src/Scanner/FunctionsScannerInterface.php
@@ -8,5 +8,5 @@ interface FunctionsScannerInterface
     /**
      * @return ParsedFunction[]
      */
-    public function scan(string $code, string $filename = null): array;
+    public function scan(string $code, string $filename): array;
 }
diff --git a/src/Scanner/Scanner.php b/src/Scanner/Scanner.php
@@ -45,7 +45,7 @@ public function scanFile(string $filename): void
         $this->scanString($string, $filename);
     }
 
-    abstract public function scanString(string $string, string $filename = null): void;
+    abstract public function scanString(string $string, string $filename): void;
 
     protected function saveTranslation(
         ?string $domain,

diff --git a/src/Scanner/ScannerInterface.php b/src/Scanner/ScannerInterface.php
@@ -18,5 +18,5 @@ public function getTranslations(): array;
 
     public function scanFile(string $filename): void;
 
-    public function scanString(string $string, string $filename = null): void;
+    public function scanString(string $string, string $filename): void;
 }