deserialize sqs message attributes #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
reviewed
Jun 14, 2019
|
|
||
| public function getAttribute(string $name, $default = null) | ||
| { | ||
| return array_key_exists($name, $this->attributes) ? $this->attributes[$name] : $default; |
There was a problem hiding this comment.
Wouldn't isset be sufficient? It is said it's a lot faster than array_key_exists with the difference that it will report null values as not set.
https://ilia.ws/archives/247-Performance-Analysis-of-isset-vs-array_key_exists.html
http://thinkofdev.com/php-fast-way-to-determine-a-key-elements-existance-in-an-array/
At least it was in 2012, but I don't think this changed.
There was a problem hiding this comment.
sure there are better ways now, return $this->attributes[$name] ?? $default, but i was copying the current style of the code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow deserializing all messages attributes, which we can use for logging and debugging.