[InfluxDB][Monitoring] Allow passing Client as configuration option. #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent calling database creation if Client driver does not support QueryDriverInterface
Steveb-p
commented
Mar 28, 2019
Prevent calling database creation if Client driver does not support QueryDriverInterface
Prevent calling database creation if Client driver does not support QueryDriverInterface
Prevent calling database creation if Client driver does not support QueryDriverInterface
Prevent calling database creation if Client driver does not support QueryDriverInterface
makasim
approved these changes
Mar 29, 2019
|
Since there are not further change requests, can I merge it myself @makasim ? (Since it's outside of my usual scope - Kafka - I don't want to impose myself) |
|
Yeap! Once approved you can merge PR. I don't do it because there might be something you want to flesh up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also prevent calling database creation if Client driver does not support QueryDriverInterface.
This is a follow up from a discussion regarding #803 and a quick talk on gitter
There are a couple of comments left that I should probably drop, but I've included them to make it clear for you why the code looks in a particular way (regarding
doWritemethod).Please tell me if there are any code style changes that you want (if you don't want
sprintfcalls maybe?) or anything else.Fixes #803.