-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception on affected record !=1 #733
Conversation
additional exception; avoid using Type::BOOLEAN.
Exception on affected record !=1.
could you please fix code style issues reported by travis? |
fixes #731 |
done |
@@ -125,10 +125,14 @@ public function send(Destination $destination, Message $message): void | |||
'queue' => Type::STRING, | |||
'time_to_live' => Type::INTEGER, | |||
'delayed_until' => Type::INTEGER, | |||
'redelivered' => Type::BOOLEAN, | |||
'redelivered' => Type::SMALLINT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange. Functional tests are working with the current code, and as far as I know doctrine should handle boolean type internally according to platform driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, should be investigated deeper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found people had similar problems with boolean. For eample https://stackoverflow.com/questions/10242312/pdo-bindvalue-with-pdoparam-bool-causes-statement-execute-to-fail-silently
Try to search "insert with PDO::PARAM_BOOL fails"
I have php 7.3 and mysql 5.7, but the issue is still here.
May be if you could use SMALLINT everywhere for the type of this field it could be a solution.
additional exception; avoid using Type::BOOLEAN