Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception on affected record !=1 #733

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Exception on affected record !=1 #733

merged 4 commits into from
Jan 22, 2019

Conversation

otzy
Copy link
Contributor

@otzy otzy commented Jan 21, 2019

additional exception; avoid using Type::BOOLEAN

otzy added 2 commits January 21, 2019 10:23
additional exception; avoid using Type::BOOLEAN.
Exception on affected record !=1.
@makasim
Copy link
Member

makasim commented Jan 21, 2019

could you please fix code style issues reported by travis?

@makasim
Copy link
Member

makasim commented Jan 21, 2019

fixes #731

@otzy
Copy link
Contributor Author

otzy commented Jan 21, 2019

done

@@ -125,10 +125,14 @@ public function send(Destination $destination, Message $message): void
'queue' => Type::STRING,
'time_to_live' => Type::INTEGER,
'delayed_until' => Type::INTEGER,
'redelivered' => Type::BOOLEAN,
'redelivered' => Type::SMALLINT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange. Functional tests are working with the current code, and as far as I know doctrine should handle boolean type internally according to platform driver.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, should be investigated deeper.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found people had similar problems with boolean. For eample https://stackoverflow.com/questions/10242312/pdo-bindvalue-with-pdoparam-bool-causes-statement-execute-to-fail-silently

Try to search "insert with PDO::PARAM_BOOL fails"
I have php 7.3 and mysql 5.7, but the issue is still here.

May be if you could use SMALLINT everywhere for the type of this field it could be a solution.

@makasim makasim merged commit d811e2f into php-enqueue:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants