New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dsn] remove commented out code #661

Merged

makasim merged 1 commit into php-enqueue:master from kunicmarko20:patch-1

Nov 28, 2018

Contributor

kunicmarko20 commented Nov 28, 2018

Was reviewing the dsn class since I plan to use it and I saw some commented code. If this was intentional just close the PR.

Looks like a nice lib, thank you!


          Update Dsn.php

abbd1a7

Member

makasim commented Nov 28, 2018

@kunicmarko20 you are right, those methods should be removed.

makasim merged commit 60674f7 into php-enqueue:master

makasim changed the title ~~Dead code?~~ [dsn] remove commented out code

kunicmarko20 deleted the patch-1 branch

November 29, 2018 09:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet